Best place to farm silver ore?

which zone has the highest spawn density?

Arathi Highlands, Thousand Needles.

i never saw much silver anywhere tbh, Gold for example is much easier to come by in STV.
You could try caves in zones that can spawn tin ore, like soutshore yeti death cave